On 05/13/2015 08:20 AM, Brad King wrote: > We could also consider moving the ".*" inside the match group > and then reporting the result in HDF5_VERSION_STRING instead > of HDF5_VERSION.
OTOH, HDF5 upstream distributes a CMake package configuration file allowing one to set HDF5_DIR. In this case find_package(HDF5) will provide HDF5_VERSION, so we should be consistent with that. I did have to update our topic for this after nightly testing because Fedora packages H5pubconf.h under a different name. I added a commit to check for a few name variants and then rebased the version patch on that: FindHDF5: Check for a few H5pubconf*.h name variants http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4bd122ad FindHDF5: Add version support http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=56858178 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
