Hi,

Here's the patch to add generator expressions to the install command 
DESTINATION option.
Let me know if that's good to go.

>@@ -216,6 +216,7 @@ void 
>cmScriptGenerator::GenerateScriptActionsPerConfig(std::ostream& os,
>         i != this->ConfigurationTypes->end(); ++i)
>       {
>       const char* config = i->c_str();
>+      this->ConfigurationName = config;
>       if(this->GeneratesForConfig(config))
>         {
>         // Generate a per-configuration block.
>

>This should not be needed if things are factored correctly.

>Everything in that block already passes "config" through as a parameter.

None of the places where I use GetDestination, except in 
cmInstallTargetGenerator, receives a config in parameter. An ideally, the 
ConfigurationName member should not even exist, but that will force all places 
to pass the config as a parameter. Imho it's better to keep refactoring in a 
separate patch.

-Robert Goulet

Attachment: install-dest-genex.patch
Description: install-dest-genex.patch

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to