On 09/22/2015 04:00 PM, Stephen Kelly wrote: > This is going in the wrong direction. > (Merge topic 'generators-use-cmLocalGenerator', 2015-08-24) > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9135e370 [snip] > The patch from Robert should not undo that effort, so the branch > should be reverted from next and not merged to master.
Thanks, Steve. I suspected this which is why I called your attention to this review. Reverted. Robert, this feature is going to have to wait until post-3.4 development opens so it can be based on Steve's refactoring work. I suspect it will be easier to implement after that refactoring anyway. Sorry this trouble was not identified earlier in review. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
