On 09/10/2015 03:04 PM, Brad King wrote: > On 09/10/2015 02:37 PM, Gilles Khouzam wrote: >> I can split it up in multiple patches if that makes it easier. > > Yes, please. That makes review and future reading of history easier > because we see a commit message associated with each corresponding > set of changes. > > Please order the patches so that no existing functionality breaks at > any step and everything compiles.
Also please produce the patches with "git format-patch" so that commit messages and authorship info comes with each one. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
