On Tue, Nov 17, 2015 at 10:12 PM, Robert Dailey <rcdailey.li...@gmail.com> wrote: > On Tue, Nov 17, 2015 at 6:57 AM, Paul Smith <p...@mad-scientist.net> wrote: >> On Tue, 2015-11-17 at 08:14 +0000, Stuermer, Michael SP/HZA-ZSEP wrote: >>> In short, there is no fully automated style checking. If someone would >>> come up with a tool & configuration I would love to use this. So far I >>> tested astyle and the C++ edition of ReSharper (unfortunately quite >>> expensive). >> >> We've used uncrustify with excellent results in the past, FWIW. >> >> It is a major hassle though. We did a complete code reformat with a >> well-defined process, and then had all developers apply reformatting to >> their personal branches using a particular set of steps to minimize the >> insanity. >> > > I'm willing to assist with a clang format file, I've worked with them > in the past. This means contributions will likely come with multiple > patch files, some containing only whitespace fixups per the clang > format. > > How did you guys want to approach reformatting inconsistently > formatted source files?
I would say: As a byproduct. Adding a .clang-format file to CMake would be greatly appreciated. It can be used to ensure that refactorings and new contributions follow exactly the predefined style. However, changing existing code simply because it does not match the style is something that should be refused. git-clang-format can fix the formatting of staged hunks without changing the rest of the files. -- Daniel -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
