On Mon, Feb 08, 2016 at 15:29:50 +0000, Antonio Pérez Barrero wrote: > thanks for feedback, I'll rework the patch. I was planning to actually > submit three patches covering the following: > > * Version checking > * Interface variables rename, keeping backwards compatibility. > * Fix a bug when setting Protobuf_LIBRARIES on Un*x systems.
Looks like a sensible breakdown to me. > So what's the best way to submit them: > > * A separate format-patch for each. This one. Sending it as a series of 3 patches is best (and easy if you use git send-email). Best is that the earlier patches fix bugs and such so that if they are OK, they're more easily applied independently if later patches have issues which need resolving yet. Thanks, --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
