On 03/19/2016 06:56 AM, Sebastian Windisch wrote:
> I like to contribute code for issue #0015146.

Thanks!

> What I did: I introduced a new flag in cmIDEFlagTable.h called
> RegularExpression

Good idea.  That should be able to handle the special parsing
mentioned in my comment in that issue:

 https://cmake.org/Bug/view.php?id=15146#c36772

> {"UACUIAccess", "MANIFESTUAC:level=([a-zA-Z]+) uiAccess=([a-zA-Z]+)$",
> "", "\\2", cmVS7FlagTable::RegularExpression},

This does not look sufficient to match the example given in the
issue description:

 -MANIFESTUAC:"level='requireAdministrator' uiAccess='false'"

IIUC the single quotes are optional as they appear to work when passed
directly on a command line build.  Also I suspect more whitespace
needs to be tolerated.

There are some existing UACExecutionLevel entries in the link flag
tables that were produced by the automated tool we use to generate
the flag tables from MSBuild files originally.  Please check that
they can be removed in favor of your new entries.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to