Am 13.04.2016 um 16:40 schrieb Brad King:
On 04/13/2016 10:08 AM, Sebastian Holtermann wrote:
Well, looking into the sources and there is already Tests/QtAutogen.
It covers various #include "moc_..." cases.
Perhaps, but as pointed out in the issue tracker entry I linked those
test cases were not sufficient to fail after the the incorrect fix
made and reverted there. Please identify why and extend them.
Now after testing it I think the incorrect fix was not incorrect at all.
The feared moc renaming was only applied to mocs that were not #included.
For not #included mocs the (not so) incorrect pach creates long moc
names in this format: moc_DIRNAME_BASENAME.cpp.
My patch creates the not #included mocs in subdirectories.
This is more robust IMO.
-Sebastian
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
