Am 14.04.2016 um 23:06 schrieb Sebastian Holtermann:

These two hunks look like error checks added to the existing logic.
Please split these out into preceding commits with their own messages
explaining the new errors.  Please also include a

  Help/release/dev/automoc-diagnostics.rst

file with a release note explaining the new diagnostics.


Wow, this turned into a git learning session for me.
Git is as awesome as it is hard.

I've split the patch into three as suggested.


Please do not commit.

After checking a greater picture and
https://cmake.org/Bug/view.php?id=16068
I found that an adapted more generic test
would help with qrc and ui file generation, too.
I'm going to start a new thread next week.

-Sebastian

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to