On 07/06/2016 03:12 PM, Dāvis Mosāns wrote: > On Windows this function returns environment variable encoded > in ANSI codepage which might not match internally used encoding. [snip] > - static const char* GetEnv(const char* key); > - static const char* GetEnv(const std::string& key); > + DEPRECATED static const char* GetEnv(const char* key); > + DEPRECATED static const char* GetEnv(const std::string& key);
Please also revise these to return the properly converted string and use a static std::map internally to manage the storage. I'd like the two overloads to at least return consistent values. The need for the internal map is a good justification for adding the deprecation mark. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
