On 07/12/2016 10:05 PM, Dāvis Mosāns wrote: > std::basic_filebuf::open(const wchar_t *) isn't part of C++ standard > and it's only present for MSVC but it isn't present in libstdc++ (MinGW) > so we implement this functionality using GNU libstdc++ stdio_filebuf > extension and _wfopen function.
Thanks. > +IF(KWSYS_USE_FStream) > + INCLUDE(CheckIncludeFileCXX) > + CHECK_INCLUDE_FILE_CXX(ext/stdio_filebuf.h HAVE_EXT_STDIO_FILEBUF_H) > + IF(HAVE_EXT_STDIO_FILEBUF_H) > + add_definitions(-DHAVE_EXT_STDIO_FILEBUF_H=1) > + ENDIF() > +ENDIF() Please use KWSYS_PLATFORM_CXX_TEST with kwsysPlatformTestsCXX.cxx to do this check, and then store the result in Configure.hxx so that KWSys clients do not have to repeat the check. See the existing case of KWSYS_STL_HAS_WSTRING for an example. We could name the new check KWSYS_CXX_HAS_EXT_STDIO_FILEBUF_H. > - class basic_ifstream : public std::basic_istream<CharType,Traits> > + class basic_efilebuf [snip] > +class basic_ifstream : public std::basic_istream<CharType,Traits>, > + public basic_efilebuf<CharType,Traits> Please split this refactoring out into a preceding commit. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
