On 08/08/2016 09:19 AM, Ben Boeckel wrote: > On Sun, Aug 07, 2016 at 04:54:52 +0200, Florent Castelli wrote: >> I'd say that you shouldn't do this unless you have tested it extensively >> with very long command lines, making sure that there is a response file >> fallback if it grows too much. >> There are issues in CMake already on Windows with long command lines and >> having even longer ones is not going to help. > > Agreed. RC files compilation already has issues in some projects without > absolute paths as is. > > https://gitlab.kitware.com/cmake/cmake/issues/16171
RC files used absolute paths prior to this patch. The patch is for other languages. Also in out-of-source builds we already use absolute paths to files in the source tree. If there are problems with command line lengths they can be addressed separately. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers