On 08/08/2016 01:42 PM, Chaoren Lin wrote:
>> I don't think this hunk is needed anymore, correct?
> 
> That hunk is the opposite now

Oops, right.  That actually fixes the existing RC bug I mentioned
earlier in this thread.

With your patch the use of IN_ABS breaks builds with spaces in the
path.  The reason is that Ninja handles quoting of paths when
replacing  the `$in` placeholder but does nothing special for
`$IN_ABS`.  CMake will have to generate the right path in the value.

I've applied the patch with the appropriate modification for that:

 Ninja: Use full path for all source files
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=955c2a63

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to