Am 2017-10-25 02:24, schrieb Alan W. Irwin:
@Matthias:

I am directly addressing you in this post because git bisect says your
recent commit is the first one that shows this issue. More details below.

commit 49287eed2bf9860919a155af848e7cf49d45f504
Author: Matthias Maennich <matth...@maennich.net>
Date:   Mon Oct 9 16:25:52 2017 +0200

    CommandArgumentParser: avoid strcpy usage

as the first commit that had the bootstrap issue.

This very much looks like a change I had in a few weeks ago but removed from there because of exactly those compile failures. This works fine with newer gcc and apparently Clang versions, but older compilers do not like it.

Looking on that code again: I don't think it is needed to have anything of that in the class. Just make this file static variables:

static const char EmptyVariable[] = "";
static char DCURLYVariable[3] = "${";

and then drop those members from the class entirely. Maybe make them static variables in the class and initialize them in the cxx file if it is needed to have them in the class. But I don't see no reason to have them as writable, instance specific class members as those values will never change.

Eike
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to