On Tue, 21 Dec 2010 20:08:51 -0600, James Cammarata <sngx-ad...@sngx.net> wrote:
> On Tue, Dec 21, 2010 at 7:40 PM, James Cammarata <sngx-ad...@sngx.net> wrote:
> > On Tue, Dec 21, 2010 at 7:37 PM, Scott Henson <shen...@redhat.com> wrote:
> >> On Tue, 21 Dec 2010 15:57:35 -0500, Chuck Short <zul...@ubuntu.com> wrote:
> >>> Hi,
> >>>
> >>> Please pull from git://github.com/zulcss/debian-cobbler.git. This branch
> >>> contains:
> >>>
> >>> * Disable the checks that are not really valid for Ubuntu or Debian.
> >>> * tftp-hpa users for both Ubuntu Debian use /var/lib/tftpboot.
> >>> * Initial commit for the Ubuntu import module.
> >>> * Initial commit for the Debian import module.
> >>>
> >>> If you have any questions please let me know.
> >>
> >> Looks good so far.  I've merged it.
> >
> > Is this using the new module format I've created, or is it all going
> > in action_import?  I just pushed my commit to github as well, was
> > gonna try and take a look at this tonight:
> >
> > commit d76d2286a4abb039b64ad829ab0bfac71b8c78ce
> > Author: James Cammarata <j...@sngx.net>
> > Date:   Tue Dec 21 19:38:34 2010 -0600
> >
> >    Finished up debian/ubuntu support for imports
> >    Tweaked redhat/vmware import modules logging output
> >    Added rsync function to utils to get it out of each module
> >     - still need to fix the redhat/vmware modules to actually use this
> >
> 
> Looking through this, there's actually quite a bit that we did
> similarly, since it is based off the other import modules I created.
> There are a couple more things cleaned up than I did, but I also
> rewrote a few significant portions myself.  One of the primary
> differences is that I combined debian and ubuntu into one module,
> since there is a lot of overlap.  I also rewrote the release detection
> code (instead of checking a deb file I read in the Release file that
> exists in the directory tree).
> 
> I should be able to merge our work together without too much of an issue.

If you are cool with the additional work, I'm fine with that.  Thanks much.

-- 
Scott Henson
Red Hat CIS Operator
WVU Alum BSAE/BSME

Attachment: pgpifyf2oTL85.pgp
Description: PGP signature

_______________________________________________
cobbler-devel mailing list
cobbler-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/cobbler-devel

Reply via email to