On Tue, Apr 23, 2019 at 12:28 AM Markus Elfring <markus.elfr...@web.de> wrote:
>
> > I would like to show you my efforts on adding the missing dowhile loop in 
> > SmPL.
>
> Do you refer to the functionality “do … while(…) loop” here?
>
> Thanks for your interest in software extensions according to this topic.
> https://systeme.lip6.fr/pipermail/cocci/2015-May/002030.html
> https://lore.kernel.org/cocci/5558ae29.6060...@users.sourceforge.net/
>

My patch tries to fix this issue, I was inspired by another discuss in
the kernel mailing list.

>
> > I think it's rustic and I could use your professional suggestions
>
> * How do you think about providing a more reasonable description also
>   in the patch file?
>
> * I would prefer your real name in the signature.
>   See also:
>   
> https://github.com/coccinelle/coccinelle/blob/848f85e256516330c06f5fd8dc782b854ed9aa03/readme.txt#L90
>

Yes, thanks, I will fix them later.

>
> > to refine the code and complete the test set.
>
> * Would you like to add a directory for your test collection?

Hum, there are over 1000 files in tests/, it's tedious to scroll
through all of them.

>
> * Will line breaks be needed at the end of text source files?
>

I don't get this, do you mean 80 chars limitation?

Thx!
Yimin
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Reply via email to