[Fwd: cvs commit: cocoon-2.1/src/java/org/apache/cocoon/servlet CocoonServlet.java]

[Nicola Ken Barozzi]

Thanks :-)

-------- Original Message --------
Subject: cvs commit: cocoon-2.1/src/java/org/apache/cocoon/servlet 
CocoonServlet.java
Date: 16 Mar 2003 14:25:31 -0000
From: [EMAIL PROTECTED]
Reply-To: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]

stefano     2003/03/16 06:25:31

  Modified:    src/java/org/apache/cocoon/servlet CocoonServlet.java
  Log:
  Cleaning up the error handling and send 404 for resource not found 
instead of 500

  Revision  Changes    Path
  1.2       +48 -51 
cocoon-2.1/src/java/org/apache/cocoon/servlet/CocoonServlet.java

  Index: CocoonServlet.java
  ===================================================================
  RCS file: 
/home/cvs/cocoon-2.1/src/java/org/apache/cocoon/servlet/CocoonServlet.java,v

...
  @@ -1074,13 +1074,14 @@
                   if (this.cocoon.process(env)) {
                       contentType = env.getContentType();
                   } else {
  -                    // NKB Should not get here?
  -                    log.fatalError("The Cocoon engine said it failed 
to process the request for an unknown reason.");
  +                    // We reach this when there is nothing in the 
processing change that matches
  +                    // the request. For example, no matcher matches.
  +                    log.fatalError("The Cocoon engine failed to 
process the request.");
                       manageException(request, res, env, uri,

HttpServletResponse.SC_INTERNAL_SERVER_ERROR,
  -                                    "Cocoon confusion",
  -                                    "Cocoon engine failed in process.",
  -                                    "The Cocoon engine said it 
failed to process the request for an unknown reason.",
  +                                    "Request Processing Failed",
  +                                    "Cocoon engine failed in process 
the request",
  +                                    "The processing engine failed to 
process the request. This could be due to lack of matching or bugs in 
the pipeline engine.",
                                       null);
                       return;
                   }
--
Nicola Ken Barozzi                   [EMAIL PROTECTED]
            - verba volant, scripta manent -
   (discussions get forgotten, just code remains)
---------------------------------------------------------------------