Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libstorage-ng for openSUSE:Factory checked in at 2026-04-10 17:49:39 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libstorage-ng (Old) and /work/SRC/openSUSE:Factory/.libstorage-ng.new.21863 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libstorage-ng" Fri Apr 10 17:49:39 2026 rev:333 rq:1345658 version:4.5.309 Changes: -------- --- /work/SRC/openSUSE:Factory/libstorage-ng/libstorage-ng.changes 2026-04-04 19:06:04.553824917 +0200 +++ /work/SRC/openSUSE:Factory/.libstorage-ng.new.21863/libstorage-ng.changes 2026-04-10 17:52:35.248779826 +0200 @@ -1,0 +2,9 @@ +Thu Apr 9 16:57:40 UTC 2026 - [email protected] + +- merge gh#openSUSE/libstorage-ng#1064 +- use modern C++ feature +- fixed typos +- add missing include statement +- 4.5.309 + +-------------------------------------------------------------------- Old: ---- libstorage-ng-4.5.308.tar.xz New: ---- libstorage-ng-4.5.309.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libstorage-ng.spec ++++++ --- /var/tmp/diff_new_pack.Cg4IXc/_old 2026-04-10 17:52:36.200819061 +0200 +++ /var/tmp/diff_new_pack.Cg4IXc/_new 2026-04-10 17:52:36.204819226 +0200 @@ -18,7 +18,7 @@ %define libname %{name}1 Name: libstorage-ng -Version: 4.5.308 +Version: 4.5.309 Release: 0 Summary: Library for storage management License: GPL-2.0-only ++++++ libstorage-ng-4.5.308.tar.xz -> libstorage-ng-4.5.309.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/VERSION new/libstorage-ng-4.5.309/VERSION --- old/libstorage-ng-4.5.308/VERSION 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/VERSION 2026-04-09 18:57:40.000000000 +0200 @@ -1 +1 @@ -4.5.308 +4.5.309 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Devicegraph.h new/libstorage-ng-4.5.309/storage/Devicegraph.h --- old/libstorage-ng-4.5.308/storage/Devicegraph.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Devicegraph.h 2026-04-09 18:57:40.000000000 +0200 @@ -129,7 +129,7 @@ /** * The main container of the libstorage-ng. * - * The devicegraph contains Devices (node) and Holders (edge). A + * The devicegraph contains Devices (nodes) and Holders (edges). A * device represent a storage object, e.g. a disk, a LVM volume * group, a file systems or a mount point. A holder represent the * connection between two devices, e.g. that a disk is used by a diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Devices/BlkDeviceImpl.h new/libstorage-ng-4.5.309/storage/Devices/BlkDeviceImpl.h --- old/libstorage-ng-4.5.308/storage/Devices/BlkDeviceImpl.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Devices/BlkDeviceImpl.h 2026-04-09 18:57:40.000000000 +0200 @@ -161,7 +161,7 @@ bool is_alias_of(const string& name) const; /** - * This is a invasive version of BlkDevice::find_by_name(). If no + * This is an invasive version of BlkDevice::find_by_name(). If no * block device is found via the name a second search via the sysfs * path is done. This requires system lookups and is also the reason * the function needs an SystemInfo object and must be used on the diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Devices/Device.h new/libstorage-ng-4.5.309/storage/Devices/Device.h --- old/libstorage-ng-4.5.308/storage/Devices/Device.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Devices/Device.h 2026-04-09 18:57:40.000000000 +0200 @@ -158,7 +158,7 @@ */ static std::vector<const Device*> get_all(const Devicegraph* devicegraph); - // TODO check if we can somehow return a iterator. getting rid of the + // TODO check if we can somehow return an iterator. Getting rid of the // ptr would also allow to use references instead of pointer in the // interface. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Devices/ImplicitPt.h new/libstorage-ng-4.5.309/storage/Devices/ImplicitPt.h --- old/libstorage-ng-4.5.308/storage/Devices/ImplicitPt.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Devices/ImplicitPt.h 2026-04-09 18:57:40.000000000 +0200 @@ -77,7 +77,7 @@ /** - * Checks whether device points to a ImplicitPt. + * Checks whether device points to an ImplicitPt. * * @throw NullPointerException */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Devices/PartitionTable.h new/libstorage-ng-4.5.309/storage/Devices/PartitionTable.h --- old/libstorage-ng-4.5.308/storage/Devices/PartitionTable.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Devices/PartitionTable.h 2026-04-09 18:57:40.000000000 +0200 @@ -121,7 +121,7 @@ unsigned int max_primary() const; /** - * Returns whether a extended partition is supported. + * Returns whether an extended partition is supported. * * This function is independent of existing partitions. */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Devices/Partitionable.h new/libstorage-ng-4.5.309/storage/Devices/Partitionable.h --- old/libstorage-ng-4.5.308/storage/Devices/Partitionable.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Devices/Partitionable.h 2026-04-09 18:57:40.000000000 +0200 @@ -86,7 +86,7 @@ /** * Create a partition table on the partitionable. * - * When creating a implicit partition table this function also creates + * When creating an implicit partition table this function also creates * the implicit partition. * * @throw WrongNumberOfChildren, UnsupportedException, Exception diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Filesystems/Bcachefs.h new/libstorage-ng-4.5.309/storage/Filesystems/Bcachefs.h --- old/libstorage-ng-4.5.308/storage/Filesystems/Bcachefs.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Filesystems/Bcachefs.h 2026-04-09 18:57:40.000000000 +0200 @@ -66,7 +66,7 @@ /** - * Checks whether device points to an Bcachefs. + * Checks whether device points to a Bcachefs. * * @throw NullPointerException */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Filesystems/Iso9660.h new/libstorage-ng-4.5.309/storage/Filesystems/Iso9660.h --- old/libstorage-ng-4.5.308/storage/Filesystems/Iso9660.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Filesystems/Iso9660.h 2026-04-09 18:57:40.000000000 +0200 @@ -67,7 +67,7 @@ /** - * Checks whether device points to a Iso9660. + * Checks whether device points to an Iso9660. * * @throw NullPointerException */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Filesystems/MountPointImpl.cc new/libstorage-ng-4.5.309/storage/Filesystems/MountPointImpl.cc --- old/libstorage-ng-4.5.308/storage/Filesystems/MountPointImpl.cc 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Filesystems/MountPointImpl.cc 2026-04-09 18:57:40.000000000 +0200 @@ -412,7 +412,7 @@ actions.push_back(make_shared<Action::RemoveFromEtcFstab>(get_sid())); } - // A unmount action could be required when the device is set as unmounted in the target system + // An unmount action could be required when the device is set as unmounted in the target system // or when some of its mount properties have changed (e.g., path, mount type). But the unmount // action only makes sense if the device is currently mounted in the system. if (lhs.active && (!active || lhs.path != path || lhs.rootprefixed != rootprefixed || diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Filesystems/Reiserfs.h new/libstorage-ng-4.5.309/storage/Filesystems/Reiserfs.h --- old/libstorage-ng-4.5.308/storage/Filesystems/Reiserfs.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Filesystems/Reiserfs.h 2026-04-09 18:57:40.000000000 +0200 @@ -65,7 +65,7 @@ /** - * Checks whether device points to an Reiserfs. + * Checks whether device points to a Reiserfs. * * @throw NullPointerException */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Filesystems/Xfs.h new/libstorage-ng-4.5.309/storage/Filesystems/Xfs.h --- old/libstorage-ng-4.5.308/storage/Filesystems/Xfs.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Filesystems/Xfs.h 2026-04-09 18:57:40.000000000 +0200 @@ -66,7 +66,7 @@ /** - * Checks whether device points to a Xfs. + * Checks whether device points to an Xfs. * * @throw NullPointerException */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Graphviz.h new/libstorage-ng-4.5.309/storage/Graphviz.h --- old/libstorage-ng-4.5.308/storage/Graphviz.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Graphviz.h 2026-04-09 18:57:40.000000000 +0200 @@ -135,7 +135,7 @@ /** - * Get a ActiongraphStyleCallbacks object for debugging. Attributes + * Get an ActiongraphStyleCallbacks object for debugging. Attributes * are likely colorful and include information like the action text * and the storage id. The attributes may change any time. */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/StorageImpl.cc new/libstorage-ng-4.5.309/storage/StorageImpl.cc --- old/libstorage-ng-4.5.308/storage/StorageImpl.cc 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/StorageImpl.cc 2026-04-09 18:57:40.000000000 +0200 @@ -394,7 +394,7 @@ Devicegraph* Storage::Impl::copy_devicegraph(const string& source_name, const string& dest_name) { - const Devicegraph* tmp1 = static_cast<const Impl*>(this)->get_devicegraph(source_name); + const Devicegraph* tmp1 = std::as_const(*this).get_devicegraph(source_name); Devicegraph* tmp2 = create_devicegraph(dest_name); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Utils/Lock.h new/libstorage-ng-4.5.309/storage/Utils/Lock.h --- old/libstorage-ng-4.5.308/storage/Utils/Lock.h 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Utils/Lock.h 2026-04-09 18:57:40.000000000 +0200 @@ -45,7 +45,7 @@ /** * pid of one of the process holding a lock. The pid is 0 if it could - * not be determined, -1 if the lock is held by a open file descriptor + * not be determined, -1 if the lock is held by an open file descriptor * lock and -2 if the lock is held by the same process. Note that the * pid may already be out of date by the time the function returns. */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.308/storage/Utils/Logger.cc new/libstorage-ng-4.5.309/storage/Utils/Logger.cc --- old/libstorage-ng-4.5.308/storage/Utils/Logger.cc 2026-04-01 16:09:25.000000000 +0200 +++ new/libstorage-ng-4.5.309/storage/Utils/Logger.cc 2026-04-09 18:57:40.000000000 +0200 @@ -23,7 +23,7 @@ #include <stdio.h> #include <fcntl.h> -/* Not technically required, but needed on some UNIX distributions */ +#include <unistd.h> #include <sys/types.h> #include <sys/stat.h>
