Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package yast2-storage-ng for 
openSUSE:Factory checked in at 2022-04-13 21:04:29
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-storage-ng (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-storage-ng.new.1900 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-storage-ng"

Wed Apr 13 21:04:29 2022 rev:123 rq:969484 version:4.5.2

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-storage-ng/yast2-storage-ng.changes        
2022-04-10 19:05:29.170445305 +0200
+++ 
/work/SRC/openSUSE:Factory/.yast2-storage-ng.new.1900/yast2-storage-ng.changes  
    2022-04-13 21:05:03.532569698 +0200
@@ -1,0 +2,8 @@
+Mon Apr 11 07:36:47 UTC 2022 - Jos?? Iv??n L??pez Gonz??lez <[email protected]>
+
+- Release sources before probing during installation to avoid
+  issues when unmounting devices (bsc#1197999 and related to
+  bsc#1196061).
+- 4.5.2
+
+-------------------------------------------------------------------
@@ -11 +19 @@
-- Bump version to 4.5.0 (#bsc1198109)
+- Bump version to 4.5.0 (bsc#1198109)

Old:
----
  yast2-storage-ng-4.5.1.tar.bz2

New:
----
  yast2-storage-ng-4.5.2.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-storage-ng.spec ++++++
--- /var/tmp/diff_new_pack.irItrW/_old  2022-04-13 21:05:04.332570337 +0200
+++ /var/tmp/diff_new_pack.irItrW/_new  2022-04-13 21:05:04.336570340 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-storage-ng
-Version:        4.5.1
+Version:        4.5.2
 Release:        0
 Summary:        YaST2 - Storage Configuration
 License:        GPL-2.0-only OR GPL-3.0-only

++++++ yast2-storage-ng-4.5.1.tar.bz2 -> yast2-storage-ng-4.5.2.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-storage-ng-4.5.1/package/yast2-storage-ng.changes 
new/yast2-storage-ng-4.5.2/package/yast2-storage-ng.changes
--- old/yast2-storage-ng-4.5.1/package/yast2-storage-ng.changes 2022-04-08 
15:39:03.000000000 +0200
+++ new/yast2-storage-ng-4.5.2/package/yast2-storage-ng.changes 2022-04-12 
13:38:25.000000000 +0200
@@ -1,4 +1,12 @@
 -------------------------------------------------------------------
+Mon Apr 11 07:36:47 UTC 2022 - Jos?? Iv??n L??pez Gonz??lez <[email protected]>
+
+- Release sources before probing during installation to avoid
+  issues when unmounting devices (bsc#1197999 and related to
+  bsc#1196061).
+- 4.5.2
+
+-------------------------------------------------------------------
 Thu Apr  7 16:29:00 UTC 2022 - Knut Anderssen <[email protected]>
 
 - Fix fstab entry filesystem matching allowing the use of quotes
@@ -8,7 +16,7 @@
 -------------------------------------------------------------------
 Wed Apr 06 13:24:58 UTC 2022 - Ladislav Slez??k <[email protected]>
 
-- Bump version to 4.5.0 (#bsc1198109)
+- Bump version to 4.5.0 (bsc#1198109)
 
 -------------------------------------------------------------------
 Thu Feb 10 10:18:23 UTC 2022 - Ancor Gonzalez Sosa <[email protected]>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-storage-ng-4.5.1/package/yast2-storage-ng.spec 
new/yast2-storage-ng-4.5.2/package/yast2-storage-ng.spec
--- old/yast2-storage-ng-4.5.1/package/yast2-storage-ng.spec    2022-04-08 
15:39:03.000000000 +0200
+++ new/yast2-storage-ng-4.5.2/package/yast2-storage-ng.spec    2022-04-12 
13:38:25.000000000 +0200
@@ -16,7 +16,7 @@
 #
 
 Name:           yast2-storage-ng
-Version:        4.5.1
+Version:        4.5.2
 Release:        0
 Summary:        YaST2 - Storage Configuration
 License:        GPL-2.0-only OR GPL-3.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-storage-ng-4.5.1/src/lib/y2storage/storage_manager.rb 
new/yast2-storage-ng-4.5.2/src/lib/y2storage/storage_manager.rb
--- old/yast2-storage-ng-4.5.1/src/lib/y2storage/storage_manager.rb     
2022-04-08 15:39:03.000000000 +0200
+++ new/yast2-storage-ng-4.5.2/src/lib/y2storage/storage_manager.rb     
2022-04-12 13:38:25.000000000 +0200
@@ -1,4 +1,4 @@
-# Copyright (c) [2015-2021] SUSE LLC
+# Copyright (c) [2015-2022] SUSE LLC
 #
 # All Rights Reserved.
 #
@@ -34,6 +34,7 @@
 
 Yast.import "Mode"
 Yast.import "Stage"
+Yast.import "Pkg"
 
 module Y2Storage
   # Singleton class to provide access to the libstorage Storage object and
@@ -183,6 +184,12 @@
     def probe!(probe_callbacks: nil)
       probe_callbacks ||= Callbacks::Probe.new
 
+      # Release all sources before probing. Otherwise, unmount action could 
fail if the mount point
+      # of the software source device is modified. Note that this is only 
necessary during the
+      # installation because libstorage-ng would try to unmount from the 
chroot path
+      # (e.g., /mnt/mount/point) and there is nothing mounted there.
+      Yast::Pkg.SourceReleaseAll if Yast::Mode.installation
+
       begin
         @storage.probe(probe_callbacks)
       rescue Storage::Aborted
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-storage-ng-4.5.1/test/y2storage/storage_manager_test.rb 
new/yast2-storage-ng-4.5.2/test/y2storage/storage_manager_test.rb
--- old/yast2-storage-ng-4.5.1/test/y2storage/storage_manager_test.rb   
2022-04-08 15:39:03.000000000 +0200
+++ new/yast2-storage-ng-4.5.2/test/y2storage/storage_manager_test.rb   
2022-04-12 13:38:25.000000000 +0200
@@ -1,6 +1,6 @@
 #!/usr/bin/env rspec
 
-# Copyright (c) [2017-2021] SUSE LLC
+# Copyright (c) [2017-2022] SUSE LLC
 #
 # All Rights Reserved.
 #
@@ -29,6 +29,7 @@
 
   before do
     described_class.create_test_instance
+    allow(Yast::Pkg).to receive(:SourceReleaseAll)
   end
 
   describe ".new" do
@@ -805,6 +806,30 @@
       expect(manager.probe!).to be_nil
     end
 
+    context "during installation" do
+      before do
+        allow(Yast::Mode).to receive(:installation).and_return(true)
+      end
+
+      it "releases software source devices before probing" do
+        expect(Yast::Pkg).to receive(:SourceReleaseAll)
+
+        manager.probe!
+      end
+    end
+
+    context "in an installed system" do
+      before do
+        allow(Yast::Mode).to receive(:installation).and_return(false)
+      end
+
+      it "does not release software source devices before probing" do
+        expect(Yast::Pkg).to_not receive(:SourceReleaseAll)
+
+        manager.probe!
+      end
+    end
+
     context "and libstorage-ng fails while probing" do
       before do
         allow(manager.storage).to receive(:probe).and_raise Storage::Exception

Reply via email to