gregfelice commented on PR #2361:
URL: https://github.com/apache/age/pull/2361#issuecomment-4129861204
Addressed both Copilot suggestions:
1. **Comment/implementation mismatch** — Updated comment to describe the
actual json-intermediate conversion path (`agtype_to_json() -> json::jsonb`)
instead of the incorrect "text intermediate".
2. **Regression tests** — Added `agtype_jsonb_cast` test suite registered in
Makefile covering:
- agtype -> jsonb: string, null, arrays (simple/nested/empty), objects
(simple/nested/with arrays/empty)
- jsonb -> agtype: all scalar types (string, int, float, bool, null),
arrays, objects
- Roundtrips: jsonb -> agtype -> jsonb for objects, arrays, null
- Graph data: vertex and edge -> jsonb with structural key checks
(`label`, `properties`, jsonb operator access)
- NULL handling: SQL NULL through both cast directions
All regression tests pass (`agtype_jsonb_cast`: ok).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
