gregfelice commented on PR #2361: URL: https://github.com/apache/age/pull/2361#issuecomment-4137212116
Rebased onto `master` (force push) — the branch previously included commit cd0aebc7 from PR #2360 (pattern expressions), which caused Copilot to flag unrelated changes (ExplainStmt comment, %expect, Makefile). The PR now contains only the 2 cast-specific commits: - `7c2c8ee2` Add agtype <-> jsonb bidirectional casts (issue #350) - `6801d3ac` Address Copilot review: fix comment, add regression tests The 3 Copilot comments about pattern expression code (cypher_gram.y comment placement, %expect/%expect-rr, Makefile scope) are no longer applicable. The 2 original Copilot suggestions (comment/implementation mismatch, regression test coverage) were already addressed in the previous round. Regression test: agtype_jsonb_cast OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
