potiuk commented on issue #4483: [AIRFLOW-3673] Add official dockerfile URL: https://github.com/apache/airflow/pull/4483#issuecomment-453738901 @Fokko @ffinfo -> what do you think about the layering approach I proposed? Do you think of any reason where it might bring problems? I think it's really bad to build the whole image as one layer. It's a best practice to leverage layer caching: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#leverage-build-cache . It used to be that you should minimize number of layers (https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#minimize-the-number-of-layers) but that was back in the old days where every single line in Dockerfile created new layer (which is not the case any more). With the proposal I have you not only minimize one-time image download but most of all you think about your users and minimize size of any future versions/incremental downloads. Even if you minimize the image to 500 MB it's not really helping users because with the current approach every time you pull new airflow image you will have 500 MB extra taken in your local docker storage (unless you run `docker system prune` this space will not be reclaimed).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
