mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract 
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r263337590
 
 

 ##########
 File path: airflow/www/templates/airflow/dags.html
 ##########
 @@ -256,11 +270,7 @@ <h2>DAGs</h2>
       });
 
       var $input = $(".typeahead");
-      unique_options_search = new Set([
-          {% for token in auto_complete_data %}
-            "{{token}}",
-          {% endfor %}
-        ]);
+      unique_options_search = new Set(getMetaValue('tokens').split(','));
 
 Review comment:
   I would like to rewrite it on Ajax to speed up page load in seperate PR. Not 
everyone uses the search engine, but everyone has all the data loaded even when 
there are a lot of them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to