mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r267568275
##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -290,6 +294,7 @@ <h4 class="modal-title" id="dagModalLabel">
{% endblock %}
{% block tail %}
{{ super() }}
+ <script src="{{ url_for_asset('utils.js') }}"></script>
Review comment:
Currently, `tail` and` tail_js` blocks are not used correctly in our
application. So the introduction of your suggestion can be problematic, because
it is difficult to predict the order in which items are loaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
