potiuk edited a comment on pull request #11157:
URL: https://github.com/apache/airflow/pull/11157#issuecomment-699919235


   I believe breeze was so far ment as a development tool -  for the people who 
have access to sources of Airflow and it is only advertised in the devlist and 
dev talks about contributing to Airflow. I don't think we ever advertised it to 
"users" of Airflow. And it is nowhere near running airflow in any "production" 
like environment - it is purely a development setup where you conveniently 
replace typing few commands with automation. 
   
   However, since you mentioned it - I think you gave birth to an idea to start 
advertising it. And I really like the idea.
   
   Breeze is already part of each release (officially) and if someone uses 
those released sources and uses Breeze from those sources, it will install the 
very version Airlfow it is the part of. So if you run Breeze from the sources 
of 1.10.13, it will install 1.10.13 by default (all technically sound - signed, 
released, and published in SVN). 
   
   This is perfectly sound with regards to Apache Release Policies I believe. 
It will use the released sources and - optionally the convenience binary images 
to rebuild the CI image and run Airflow. Unless there is something I missed 
this is perfectly OK with the release policy.
   
   And with the addition of `start-airflow` command, Breeze actually becomes a 
very useful tool for users as well to test their DAGs, so I think it might be a 
good time to think about a section of "How to test your DAGs" in the 
documentation and point it to Breeze (the officially released one in sources). 
We can even make some instructions for the users on how to run their "DAG 
testing" environment easily. It literally requires just explanation in the 
documentation and nothing else - everything else is already in 1.10.13 when we 
release it.
   
   Also, we can mention that the (1.10.13 released) version can be used to test 
any other Airflow Release. When you run `start-airflow` you can also add 
--install-airflow-version X.Y.Z (for example 1.10.13rc1 if we have it) to 
install Airflow from PyPI or --install-airflow-reference 1.10.12rc1 to install 
it from Github tag (or any other Git reference with that regard). This is not 
auto-completable or presented as available option in --help  (only the 
officially released versions are). This is something you have to do explicitly 
- knowing the version/tag you want to have, similarly as `pip install 
apache-airflow==1.10.13rc1`.
   
   This is pretty much what I was doing to test if the RC candidates work (and 
we described it in dev/README). I got airflow sources from .tar.gz source 
package from SVN but then I installed it using --install-airflow-version 
1.10.12rc3. 
   
   Now with `start-airflow` command, it's even better because I always did 
exactly this, started tmux session, initialized the db, created users, started 
webserver and scheduler. Now this all happens automatically, which is cool. 
Also 1.10.13 version has an extra `--with-rbac` option that will allow to start 
an RBAC/non-RBAC version of airflow this way which I also used during testing.
   
   Do you think there is any danger with violating Policies @ashb if we do that 
and announce it as a tool for users to test their DAGs?  I think - since 
everything is released in sources and available to build by they users with the 
right "platform and tools", this sounds pretty much OK? 
   
   Do you have any concerns if we start announcing it to the users? I think it 
is a really handy tool for them now.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to