mik-laj commented on a change in pull request #12742:
URL: https://github.com/apache/airflow/pull/12742#discussion_r533703135
##########
File path: tests/core/test_configuration.py
##########
@@ -557,6 +557,23 @@ def test_command_from_env(self):
# the environment variable's echo command
self.assertEqual(test_cmdenv_conf.get('testcmdenv',
'notacommand'), 'OK')
+ def test_sensitive_config_values(self):
Review comment:
How is this supposed to prevent aggression? I think during the review,
this value will be added to the two arrays and no one will see the difference
until they execute the operator.
##########
File path: tests/core/test_configuration.py
##########
@@ -557,6 +557,23 @@ def test_command_from_env(self):
# the environment variable's echo command
self.assertEqual(test_cmdenv_conf.get('testcmdenv',
'notacommand'), 'OK')
+ def test_sensitive_config_values(self):
Review comment:
How is this supposed to prevent reggression? I think during the review,
this value will be added to the two arrays and no one will see the difference
until they execute the operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
