turbaszek commented on a change in pull request #12742:
URL: https://github.com/apache/airflow/pull/12742#discussion_r533796183
##########
File path: tests/core/test_configuration.py
##########
@@ -557,6 +557,23 @@ def test_command_from_env(self):
# the environment variable's echo command
self.assertEqual(test_cmdenv_conf.get('testcmdenv',
'notacommand'), 'OK')
+ def test_sensitive_config_values(self):
Review comment:
> This is what I meant:
>
> ```python
> assert DataProcSparkOperator.template_fields == ['arguments', 'job_name',
'cluster_name', 'region', 'dataproc_jars', 'dataproc_properties']
> ```
On this one I must agree with Kamil. This test is useless. This test will
work even if someone renames `self.job_name` to `self.magic_dataproc_job_name`.
The proper test would be like:
```py
assert all(t in op.__dict__ for t in op.template_fileds)
```
the problem if I'm not mistaken arises when there's difference between
`template_fields` and operator attributes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
