dimon222 commented on a change in pull request #19726: URL: https://github.com/apache/airflow/pull/19726#discussion_r763427426
########## File path: airflow/providers/cncf/kubernetes/backcompat/backwards_compat_converters.py ########## @@ -21,18 +21,16 @@ from kubernetes.client import ApiClient, models as k8s from airflow.exceptions import AirflowException -from airflow.providers.cncf.kubernetes.backcompat.pod import Port, Resources -from airflow.providers.cncf.kubernetes.backcompat.pod_runtime_info_env import PodRuntimeInfoEnv -def _convert_kube_model_object(obj, old_class, new_class): +def _convert_kube_model_object(obj, old_class_name, new_class): Review comment: We're converting it on the fly (by checking if method for export as k8s class is present). So old class is not a blocker but rather a suggestion if user provided something completely unrelated in there (at least based on what I understood) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org