jedcunningham commented on a change in pull request #21501:
URL: https://github.com/apache/airflow/pull/21501#discussion_r804348257
##########
File path: tests/models/test_dagbag.py
##########
@@ -206,6 +207,49 @@ def test_zip(self):
assert dagbag.get_dag("test_zip_dag")
assert sys.path == syspath_before # sys.path doesn't change
+ @patch("airflow.models.dagbag.timeout")
+ @patch("airflow.models.dagbag.settings.get_dagbag_import_timeout")
+ def test_process_dag_file_without_timeout(self,
mocked_get_dagbag_import_timeout, mocked_timeout):
+ """
+ Test dag file parsing without timeout
+ """
+ mocked_get_dagbag_import_timeout.return_value = 0
Review comment:
We should also check with a negative, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
