jedcunningham commented on a change in pull request #21501:
URL: https://github.com/apache/airflow/pull/21501#discussion_r804712162
##########
File path: tests/models/test_dagbag.py
##########
@@ -206,6 +207,49 @@ def test_zip(self):
assert dagbag.get_dag("test_zip_dag")
assert sys.path == syspath_before # sys.path doesn't change
+ @patch("airflow.models.dagbag.timeout")
+ @patch("airflow.models.dagbag.settings.get_dagbag_import_timeout")
+ def test_process_dag_file_without_timeout(self,
mocked_get_dagbag_import_timeout, mocked_timeout):
+ """
+ Test dag file parsing without timeout
+ """
+ mocked_get_dagbag_import_timeout.return_value = 0
+
+ dagbag = models.DagBag(dag_folder=self.empty_dir,
include_examples=False)
+ dagbag.process_file(os.path.join(TEST_DAGS_FOLDER,
'test_default_views.py'))
+ mocked_timeout.assert_not_called()
+
+ @patch("airflow.models.dagbag.timeout")
+ @patch("airflow.models.dagbag.settings.get_dagbag_import_timeout")
+ def test_process_dag_file_with_non_default_timeout(
+ self, mocked_get_dagbag_import_timeout, mocked_timeout
+ ):
+ """
+ Test customized dag file parsing timeout
+ """
+ timeout_value = 100
+ mocked_get_dagbag_import_timeout.return_value = timeout_value
+
+ # ensure the test value is not equal to the default value
+ assert timeout_value != settings.conf.getfloat('core',
'DAGBAG_IMPORT_TIMEOUT')
+
+ dagbag = models.DagBag(dag_folder=self.empty_dir,
include_examples=False)
+ dagbag.process_file(os.path.join(TEST_DAGS_FOLDER,
'test_default_views.py'))
+
+ mocked_timeout.assert_called_once_with(timeout_value,
error_message=mock.ANY)
+
+ @patch("airflow.models.dagbag.settings.get_dagbag_import_timeout")
+ def test_check_value_type_from_get_dagbag_import_timeout(self,
mocked_get_dagbag_import_timeout):
+ """
+ Test correctness of value from get_dagbag_import_timeout
+ """
+ mocked_get_dagbag_import_timeout.return_value = '1'
Review comment:
🤦♂️ Oops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
