potiuk commented on code in PR #23052:
URL: https://github.com/apache/airflow/pull/23052#discussion_r853029335
##########
dev/breeze/src/airflow_breeze/breeze.py:
##########
@@ -1486,5 +1487,47 @@ def __init__(self, **kwargs):
width=os.environ.get('RECORD_BREEZE_WIDTH'),
)
+
[email protected](name='exec')
+@option_verbose
+@option_dry_run
[email protected]('exec_args', nargs=-1, type=click.UNPROCESSED)
+def exec(
+ verbose: bool, dry_run: bool, exec_args: Tuple
+):
+ dc_run_file = BUILD_CACHE_DIR / DOCKER_COMPOSE_RUN_SCRIPT_FOR_CI
+ params = BuildCiParams()
+ ci_image_name = params.airflow_image_name
+ check_docker_resources(verbose, ci_image_name)
+ cmd = [str(dc_run_file), 'ps']
Review Comment:
Not sure entirely ;) . Docker and Docker compose filters are pretty weakly
documented. But filter "give me container of the `aiflow` service" is what we
are looking for. In the `base.yml` we have:
```
version: "3.7"
services:
airflow:
image: ${AIRFLOW_CI_IMAGE_WITH_TAG}
```
So our container for airflow will always run with "airflow" service.
##########
dev/breeze/src/airflow_breeze/breeze.py:
##########
@@ -1486,5 +1487,47 @@ def __init__(self, **kwargs):
width=os.environ.get('RECORD_BREEZE_WIDTH'),
)
+
[email protected](name='exec')
+@option_verbose
+@option_dry_run
[email protected]('exec_args', nargs=-1, type=click.UNPROCESSED)
+def exec(
+ verbose: bool, dry_run: bool, exec_args: Tuple
+):
+ dc_run_file = BUILD_CACHE_DIR / DOCKER_COMPOSE_RUN_SCRIPT_FOR_CI
+ params = BuildCiParams()
+ ci_image_name = params.airflow_image_name
+ check_docker_resources(verbose, ci_image_name)
+ cmd = [str(dc_run_file), 'ps']
Review Comment:
Not sure entirely ;) . Docker and Docker compose filters are pretty weakly
documented. But filter "give me container of the `aiflow` service" is what we
are looking for. In the `base.yml` we have:
```
version: "3.7"
services:
airflow:
image: ${AIRFLOW_CI_IMAGE_WITH_TAG}
```
So our container for airflow will always run as "airflow" service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
