potiuk commented on PR #23052:
URL: https://github.com/apache/airflow/pull/23052#issuecomment-1105099543
> @potiuk Do I need to make any modifications in this PR wrt your current
changes?
Not really - I think the only change that I applied that woudl affect this
one is a little bit "nicer" handling of run_command results: when check = False
but we actually care about the success/failure (for example when I run parallel
runs). I think in this case just printing output is fine (I commented it) as
exec is really 'interactive only' but it would be nice to catch the process
return code and sys.exit() with it:
smth like:
```
process = run_command()
if not process:
sys.exit(1)
sys,exit(process.returncode)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
