potiuk commented on PR #23335:
URL: https://github.com/apache/airflow/pull/23335#issuecomment-1112682599
BTW. One more thing.
With the timeout - you have not accounted for two things.
1) the message is going to be repeated multiple times. when people will run
it. So what I am counting on is the time of displaying the message to be
multiplied by the number of times people see it.
2) You have not taken into account scrolling the terminal back. Your logic
breaks when you proposed "just print warning". If we follow your min 30 seconds
and take it literaly, this means that any warning printed is never read. If you
take it to extreme, you should never print any message to the user that might
potentially lead to an action from the user side. Which is absurd when it comes
to CLI. When peopel will experience errors later, they will likely scroll up to
see what was there before - or - in the worst case copy&paste the output if we
ask them to. So they will be able to see that message, read and ponder if the
fact they did not answer "y" might be the reason for failure. And they might
try again. This sis what I really want to induxe here. This is subtlle and not
0/1 but well, this is playing to human psychology and it's rarely 0/1 there are
shades og gray.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
