Taragolis commented on PR #26162: URL: https://github.com/apache/airflow/pull/26162#issuecomment-1237604280
> I think this is good idea, but the ECRDockerCredentialHelper should be part of Amazon provider Yeah it could be. I put it into docker provider for reduce complexity of dependency. > and likely there should be an ECRDockerOperator that uses it by default Why I move this part inside of DockerHook hook: 1. `docker_conn_id` not only use in DockerOperator also it use in `DockerSwarmOperator` and `@task.docker` task-flow decorator which won't work with `EcrDockerOperator` 2. This is optional parameter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
