potiuk commented on PR #26162: URL: https://github.com/apache/airflow/pull/26162#issuecomment-1237993733
> @potiuk FYI: The same problem exists in Postgres hook: > > Yeah it could be. I put it into docker provider for reduce complexity of dependency. > And also AWS RDS IAM auth exists in MySQLHook. However I don't think it even works in MySQL case I tihnk this should be changed then also in Postgres and MyuSQL :) . The approach wwhere "all AWS" goes to AWS actually makes dependencies less not more complex for the user. I thik we should avoid any kind of circular dependencies and we won't avoid them if "mysql" provider refers to "aws" one. Both Postgres and MySQL impementation with local imports are making the dependencies equally (or even more) complex, but they are worse because they are "hidden". If you want to reason for example "which version of AWS provider we should have in order to make Postgres work with AWS" - it is impossible to answer, because by using local imports we are hiding the fact that there is depedency (but is there but implicit and hidden). I think making an explicit dependency chain AWS -> POSTGRES, MSQL -> COMMON.SQL is the only reasonable approach. and moving "AWS specific Postgres -related classes" should be in AWS. * COMMON.SQL -> should have only generic SQL * POSTGRES -> should add postgres functionality on top * AWS -> shoudl add AWS-specific postgres extensions IMHO This is our ultimate goal even if there are are cases that are not following this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
