dakshin-k commented on code in PR #26949:
URL: https://github.com/apache/airflow/pull/26949#discussion_r996400518
##########
airflow/providers/amazon/aws/hooks/emr.py:
##########
@@ -118,13 +128,13 @@ def create_job_flow(self, job_flow_overrides: dict[str,
Any]) -> dict[str, Any]:
stacklevel=2,
)
config = emr_conn.extra_dejson.copy()
- config.update(job_flow_overrides)
+ config.update(**job_flow_overrides)
Review Comment:
@o-nikolas:
Thank you for the example, that helped me understand the difference.
>it puts the constraint on the keys that they must be valid python
variable/argument names
I agree, however, I believe this constraint is already present on that
variable. Please see the usage
[here](https://github.com/apache/airflow/blob/fb741fd87254e235f99d7d67e558dafad601f253/airflow/providers/amazon/aws/hooks/emr.py#L121-L123)
- `job_flow_overrides` is used purely to build the `config` dictionary, and
that one is used in `run_job_flow(**config)`, hence all keys in there need to
be valid identifiers anyway.
If I am mistaken, another option is to replace this line with
`config.update(dict(job_flow_overrides))` which removes the constraint on
`job_flow_overrides`.
Can you please let me know how to proceed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
