dstandish commented on code in PR #27514:
URL: https://github.com/apache/airflow/pull/27514#discussion_r1016135342
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -114,6 +114,7 @@ def __init__(self, *args, schema: str | None = None,
log_sql: bool = True, **kwa
# Hook deriving from the DBApiHook to still have access to the field
in it's constructor
self.__schema = schema
self.log_sql = log_sql
+ self.query_ids: list[str] = []
Review Comment:
I understand, but we don't need to stick with the old naming, especially
when adding to new base hook. I think it's good to specify what kind of query
ids. but in this case they aren't actually running queries so it's in some ways
a moot point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
