eladkal commented on code in PR #27514:
URL: https://github.com/apache/airflow/pull/27514#discussion_r1017018518
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -264,6 +266,7 @@ def run(
results = []
for sql_statement in sql:
self._run_command(cur, sql_statement, parameters)
+ self._update_query_ids(cur)
Review Comment:
In snowflake you can kill query by query_id assuming you know it or by
killing all queries of the session.
My point for on_kill() was that if at the end each provider will need it's
own on_kill() then it means that we will not have 1 class to serve them all so
every provider will need to inherit from SqlExecuteQueryOperator.
I want to avoid all providers doing:
```
class SnowflakeExecuteQueryOperator(SqlExecuteQueryOperator):
def on_kill():
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
