Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058572636
########## tests/providers/conftest.py: ########## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import pytest + +from tests.test_utils import db + +# Providers with subpackages +INNER_PROVIDERS = { Review Comment: > But the same kind of problem happened on multiple occasions for all kinds of tests, not only between providers. The mechanism is the same - data created in one test (in unrelated package) might impact tests from another package. So I think if we attempt to do such isolation, it should be done across the board. Then I suggest to do in a different way. Because such side effect outside of Providers could happened only when two PR merged and create this stuff 1. Migrate all test to pytest (there is less then 100 modules remaining) 2. Create separate pytest plugin with fixtures/context managers 3. Migrate all current tests to use this fixtures, most of them already exists in [conftest.py](https://github.com/apache/airflow/blob/main/tests/conftest.py) 4. Restrict manually create DAGs, TIs and etc and allow only by fixtures/context managers (more tricky part) 5. All core functionality should have setup and teardown which cleanup (most of them already have) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
