Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058578673
########## tests/providers/conftest.py: ########## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import pytest + +from tests.test_utils import db + +# Providers with subpackages +INNER_PROVIDERS = { Review Comment: > See the videos above (that's the native env).. It is noticeable, a lot. I think this happen because Init DB required load Flask and their dependencies. All other tests right not use reset db / init db for cleanup their states. Instead of just run direct queries by this module: https://github.com/apache/airflow/blob/main/tests/test_utils/db.py which run pretty fast I agree that the current solution a bit dumb but the main target right now reduce chance of side-effects between different providers tests, and the cost about 0.2 sec on single test or +0.2 (plus additional for not expensive logic) on single provider package. A lot of chance that this solution do not required as soon as we change structure of providers tests. For all tests we should consider to use different approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
