dstandish commented on code in PR #28981:
URL: https://github.com/apache/airflow/pull/28981#discussion_r1082903938
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -168,6 +168,9 @@ class KubernetesPodOperator(BaseOperator):
:param labels: labels to apply to the Pod. (templated)
:param startup_timeout_seconds: timeout in seconds to startup the pod.
:param get_logs: get the stdout of the container as logs of the tasks.
+ :param log_containers: list of container names or bool value to collect
logs.
+ If bool value is True, all container logs are collected,
+ if False, only 'base' container logs are collected.
Review Comment:
I think @uranusjr 's suggestion makes sense.
But maybe we can avoid adding another parameter since there's already a
get_logs param.
Current behavior of get_logs is base cont if True or none if false.
We could change meaning of True to get all containers. This would be change
in behavoir but nonbreaking.
Aternatively, we could leave True to mean base container and add a sentinel
value like ALL_CONTAINERS to get all containers. WDYT @mlnsharma @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
