mlnsharma commented on code in PR #28981:
URL: https://github.com/apache/airflow/pull/28981#discussion_r1089715650
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -168,6 +168,9 @@ class KubernetesPodOperator(BaseOperator):
:param labels: labels to apply to the Pod. (templated)
:param startup_timeout_seconds: timeout in seconds to startup the pod.
:param get_logs: get the stdout of the container as logs of the tasks.
+ :param log_containers: list of container names or bool value to collect
logs.
+ If bool value is True, all container logs are collected,
+ if False, only 'base' container logs are collected.
Review Comment:
Hi @potiuk Thanks for the detailed response, I agree with your comments and
hope to conclude it sooner by incorporating everyone's comments.
HI @uranusjr @dstandish Thanks for your reviewing my code & providing
comments. As @dstandish commented, I can make use of the same 'get_logs' param
to take the input. What do you suggest about having below options for the param
value?
- True: log all containers except airflow-xcom-sidecar container
- False: no logging of containers, as it is today
- list[str]: log containers specified by user
Apart from logging all containers, it also gives user an option to filter
logging of containers. I hope this also makes it easier to understand. Please
let me know your thoughts, I can make changes based on your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
