vandonr-amz commented on code in PR #29165:
URL: https://github.com/apache/airflow/pull/29165#discussion_r1087104394
##########
tests/system/providers/amazon/aws/example_sagemaker.py:
##########
@@ -161,8 +161,12 @@ def _build_and_upload_docker_image(preprocess_script,
repository_uri):
docker_build_and_push_commands = f"""
cp /root/.aws/credentials /tmp/credentials &&
+ # login to public ecr repo containing amazonlinux image
+ docker login --username {username} --password {password}
public.ecr.aws
Review Comment:
found some info here:
https://aws.amazon.com/blogs/aws/amazon-ecr-public-a-new-public-container-registry/
```Anyone who pulls images anonymously will get 500 GB of free data
bandwidth each month, after which they can sign up or sign in to an AWS account
to get more. Simply authenticating with an AWS account increases free data
bandwidth up to 5 TB each month when pulling images from the internet.```
AmazonLinux is a ~100MB download, so we can pull it 5000 times a month, or
roughly 7 times/hour without being authenticated.
BUT the problem we have is that usually those unauthenticated quotas are
applied per IP, and those IPs can be reused, so we're not the only ones on the
quota.
I think it's just safer to login and not worry about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
