vandonr-amz commented on code in PR #29165:
URL: https://github.com/apache/airflow/pull/29165#discussion_r1087217539
##########
tests/system/providers/amazon/aws/example_sagemaker.py:
##########
@@ -161,8 +161,12 @@ def _build_and_upload_docker_image(preprocess_script,
repository_uri):
docker_build_and_push_commands = f"""
cp /root/.aws/credentials /tmp/credentials &&
+ # login to public ecr repo containing amazonlinux image
+ docker login --username {username} --password {password}
public.ecr.aws
docker build --platform=linux/amd64 -f {dockerfile.name} -t
{repository_uri} /tmp &&
rm /tmp/credentials &&
+
+ # login again, this time to the private repo we created to hold
that specific image
aws ecr get-login-password --region {ecr_region} |
docker login --username {username} --password {password}
{repository_uri} &&
docker push {repository_uri}
Review Comment:
oh yes nice this pushes the weird logic of decoding the credentials out of
here which is good.
However I don't think we need anything special for the public ECR since it's
using the same credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
