ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303056781
########## File path: scripts/ci/docker-compose-local.yml ########## @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +version: "2.2" +services: + airflow-testing: + volumes: + - ../../airflow:/opt/airflow/airflow + - ../../setup.cfg:/opt/airflow/setup.cfg + - ../../setup.py:/opt/airflow/setup.py + - ../../dags:/opt/airflow/dags + - ../../dev:/opt/airflow/dev + - ../../docs:/opt/airflow/docs + - ../../hooks:/opt/airflow/hooks + - ../../scripts:/opt/airflow/scripts + - ../../tests:/opt/airflow/tests + - ../../.coveragerc:/opt/airflow/.coveragerc + - ../../LICENSE:/opt/airflow/LICENSE + - ../../MANIFEST.in:/opt/airflow/MANIFEST.in + - ../../NOTICE:/opt/airflow/NOTICE + - ../../CHANGELOG.txt:/opt/airflow/CHANGELOG + - ../../.github:/opt/airflow/.github + - ../../.flake8:/opt/airflow/.flake8 + - ../../pylintrc:/opt/airflow/pylintrc + - ../../.rat-excludes:/opt/airflow/.rat-excludes + - ../../run-tests:/opt/airflow/run-tests + - ../../logs:/root/airflow/logs Review comment: Was there a reason you did it this way this instead of ``` - ../../:/opt/airflow - ../../logs:/root/airflow/logs ``` (For example, this doesn't mount `.mypy_cache/` which will slow down running mypy the first time in each container. Not the end of the world, but mounting it may be an idea if we keep it this way) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
