vandonr-amz commented on code in PR #29245: URL: https://github.com/apache/airflow/pull/29245#discussion_r1092360487
########## airflow/providers/amazon/aws/operators/sagemaker.py: ########## @@ -679,11 +697,11 @@ def __init__( self.check_interval = check_interval self.max_ingestion_time = max_ingestion_time self.check_if_job_exists = check_if_job_exists - if action_if_job_exists in ("increment", "fail"): + if action_if_job_exists in {"random", "increment", "fail"}: Review Comment: also, the "shape" of the naming is still the same, if a regex had been designed for the old code, the new code would pass it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org