vandonr-amz commented on code in PR #29245:
URL: https://github.com/apache/airflow/pull/29245#discussion_r1092382659
##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -654,8 +673,8 @@ class SageMakerTrainingOperator(SageMakerBaseOperator):
the operation does not timeout.
:param check_if_job_exists: If set to true, then the operator will check
whether a training job
already exists for the name in the config.
- :param action_if_job_exists: Behaviour if the job name already exists.
Possible options are "increment"
- (default) and "fail".
+ :param action_if_job_exists: Behaviour if the job name already exists.
Possible options are "random"
+ (default), "increment" (deprecated) and "fail".
Review Comment:
I didn't because the behavior is the same as "random" in my proposed code,
so there is really no specific action required from users, I'd just prefer new
code to use the "right" value.
But if we want to maintain the old behavior, then I'd add a warning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
