hussein-awala commented on PR #31465:
URL: https://github.com/apache/airflow/pull/31465#issuecomment-1558778003

   @uranusjr IMO there should not be any problem if the user provide this kind 
of hosts, since it's a valid host but with a protocol, for ex, if we create the 
same connection from the UI:
   
![image](https://github.com/apache/airflow/assets/21311487/e9531344-91e6-4119-8548-15346b2962d7)
   
   Then we use the Airflow CLI to get the connection information:
   ```
   root@55c0591cd327:/opt/airflow# airflow connections get test_conn
   id | conn_id   | conn_type | description | host            | schema | login 
| password | port | is_encrypted | is_extra_encrypted | extra_dejson       | 
get_uri                                                   
   
===+===========+===========+=============+=================+========+=======+==========+======+==============+====================+====================+===========================================================
   1  | test_conn | generic   |             | protocol://host |        | user  
| pass     | 123  | False        | False              | {'param': 'value'} | 
generic://user:pass@protocol%3A%2F%2Fhost:123/?param=value
   ```
   We see that it's successfully parsed and we can use it without any problem, 
and if I think that the method `parse_uri` in the connection class should parse 
the generated uri and create the same connection from it. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to