hussein-awala commented on PR #31465:
URL: https://github.com/apache/airflow/pull/31465#issuecomment-1559435808

   I think we can add a new column to specify the protocol:
   ![Screenshot from 2023-05-23 
15-16-22](https://github.com/apache/airflow/assets/21311487/a28f5123-2346-40f2-b063-d3b02341f600)
   ![Screenshot from 2023-05-23 
15-31-32](https://github.com/apache/airflow/assets/21311487/096f1471-f167-4727-9a79-dd5fed323a91)
   
   Which is cleaner and easily supported by the uri parsing:
   ```
   root@cb473c029341:/opt/airflow# airflow connections get spark_on_k8s_conn
   id | conn_id           | conn_type | description | host       | schema | 
login | password | port | is_encrypted | is_extra_encrypted | extra_dejson      
         | get_uri                                        
   
===+===================+===========+=============+============+========+=======+==========+======+==============+====================+============================+================================================
   1  | spark_on_k8s_conn | spark     |             | 100.68.0.1 |        |     
  | None     | 443  | False        | False              | {'deploy-mode': 
'cluster'} | spark://k8s://100.68.0.1:443/?deploy-mode=clust
      |                   |           |             |            |        |     
  |          |      |              |                    |                       
     | er                                             
                                                                                
                                                                                
                                                      
   root@cb473c029341:/opt/airflow# airflow connections get test_conn
   id | conn_id   | conn_type | description      | host | schema | login | 
password | port | is_encrypted | is_extra_encrypted | extra_dejson       | 
get_uri                                                   
   
===+===========+===========+==================+======+========+=======+==========+======+==============+====================+====================+===========================================================
   2  | test_conn | generic   | test description | host | schema | user  | pass 
    | 123  | False        | False              | {'param': 'value'} | 
generic://protocol://user:pass@host:123/schema?param=value 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to