Bowrna commented on code in PR #31996:
URL: https://github.com/apache/airflow/pull/31996#discussion_r1268918807


##########
airflow/jobs/job.py:
##########
@@ -207,7 +207,16 @@ def heartbeat(
                 self.log.debug("[heartbeat]")
         except OperationalError:
             Stats.incr(convert_camel_to_snake(self.__class__.__name__) + 
"_heartbeat_failure", 1, 1)
-            self.log.exception("%s heartbeat got an exception", 
self.__class__.__name__)
+            if self.is_alive():
+                self.log.error(
+                    "%s heartbeat failed with error. Scheduler may go into 
unhealthy state",

Review Comment:
   @potiuk Do you want to explain in detail why the scheduler may go to an 
unhealthy state? If yes, how do I find the list of possible cases when it may 
go into the unhealthy state?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to